//
//  Copyright (C) 2016-2023 Greg Landrum
//
//   @@ All Rights Reserved @@
//  This file is part of the RDKit.
//  The contents are covered by the terms of the BSD license
//  which is included in the file license.txt, found at the root
//  of the RDKit source tree.
//
#include <catch2/catch_all.hpp>
#include <RDGeneral/test.h>
#include <string>
#include <vector>
#include <GraphMol/RDKitBase.h>
#include <GraphMol/test_fixtures.h>
#include <GraphMol/FileParsers/FileParsers.h>
#include <GraphMol/FileParsers/MolFileStereochem.h>
#include <GraphMol/MarvinParse/MarvinParser.h>
#include <GraphMol/Chirality.h>
#include <GraphMol/SmilesParse/CanonicalizeStereoGroups.h>
#include <GraphMol/SmilesParse/SmilesJSONParsers.h>
#include "SmilesParse.h"
#include "SmilesWrite.h"
#include "SmartsWrite.h"
#include <RDGeneral/RDLog.h>
#include <fstream>

constexpr bool GenerateExpectedFiles = false;

using namespace RDKit;

TEST_CASE("base functionality") {
  {  // it works when nothing is provided
    std::string smiles = "CC";
    SmilesParserParams params;
    params.allowCXSMILES = true;
    ROMol *m = SmilesToMol(smiles, params);
    REQUIRE(m);
    CHECK(m->getNumAtoms() == 2);
    delete m;
  }
}
TEST_CASE("reading 2D coordinates") {
  {
    std::string smiles = "CC |(0,.75,;0,-.75,)|";
    SmilesParserParams params;
    params.allowCXSMILES = true;
    ROMol *m = SmilesToMol(smiles, params);
    REQUIRE(m);
    CHECK(m->getNumAtoms() == 2);
    CHECK(m->getNumConformers() == 1);
    CHECK(fabs(m->getConformer().getAtomPos(0).x) < 1e-4);
    CHECK(fabs(m->getConformer().getAtomPos(0).y - 0.75) < 1e-4);
    CHECK(fabs(m->getConformer().getAtomPos(0).z) < 1e-4);
    CHECK(fabs(m->getConformer().getAtomPos(1).x) < 1e-4);
    CHECK(fabs(m->getConformer().getAtomPos(1).y + 0.75) < 1e-4);
    CHECK(fabs(m->getConformer().getAtomPos(1).z) < 1e-4);

    delete m;
  }
  {
    std::string smiles = "CC |(,,;,,-.75)|";
    SmilesParserParams params;
    params.allowCXSMILES = true;
    ROMol *m = SmilesToMol(smiles, params);
    REQUIRE(m);
    CHECK(m->getNumAtoms() == 2);
    CHECK(m->getNumConformers() == 1);
    CHECK(fabs(m->getConformer().getAtomPos(0).x) < 1e-4);
    CHECK(fabs(m->getConformer().getAtomPos(0).y) < 1e-4);
    CHECK(fabs(m->getConformer().getAtomPos(0).z) < 1e-4);
    CHECK(fabs(m->getConformer().getAtomPos(1).x) < 1e-4);
    CHECK(fabs(m->getConformer().getAtomPos(1).y) < 1e-4);
    CHECK(fabs(m->getConformer().getAtomPos(1).z + 0.75) < 1e-4);

    delete m;
  }
}

TEST_CASE("reading Atom Labels") {
  {
    std::string smiles = "CCC |$foo;;bar$|";
    SmilesParserParams params;
    params.allowCXSMILES = true;
    ROMol *m = SmilesToMol(smiles, params);
    REQUIRE(m);
    CHECK(m->getNumAtoms() == 3);
    CHECK(m->getAtomWithIdx(0)->getProp<std::string>(
              common_properties::atomLabel) == "foo");
    CHECK(m->getAtomWithIdx(2)->getProp<std::string>(
              common_properties::atomLabel) == "bar");
    CHECK(!m->getAtomWithIdx(1)->hasProp(common_properties::atomLabel));
    delete m;
  }
  {  // attachment points, example from the docs
    std::string smiles = "C[C@H](N*)C(*)=O |$;;;_AP1;;_AP2;$|";
    SmilesParserParams params;
    params.allowCXSMILES = true;
    ROMol *m = SmilesToMol(smiles, params);
    REQUIRE(m);
    CHECK(m->getNumAtoms() == 7);
    CHECK(m->getAtomWithIdx(3)->getAtomicNum() == 0);
    CHECK(m->getAtomWithIdx(3)->getProp<std::string>(
              common_properties::atomLabel) == "_AP1");
    // we used to set an atom map for attachment points. This was github #3393
    CHECK(m->getAtomWithIdx(3)->getAtomMapNum() == 0);
    // check the _fromAttachPoint property, added as part of github #7078
    CHECK(m->getAtomWithIdx(3)->getProp<int>(
              common_properties::_fromAttachPoint) == 1);

    CHECK(m->getAtomWithIdx(5)->getAtomicNum() == 0);
    CHECK(m->getAtomWithIdx(5)->getProp<std::string>(
              common_properties::atomLabel) == "_AP2");
    // we used to set an atom map for attachment points. This was github #3393
    CHECK(m->getAtomWithIdx(5)->getAtomMapNum() == 0);
    // check the _fromAttachPoint property, added as part of github #7078
    CHECK(m->getAtomWithIdx(5)->getProp<int>(
              common_properties::_fromAttachPoint) == 2);

    delete m;
  }
  {  // query properties
    std::string smiles = "**C |$Q_e;QH_p;;$|";
    SmilesParserParams params;
    params.allowCXSMILES = true;
    ROMol *m = SmilesToMol(smiles, params);
    REQUIRE(m);
    CHECK(m->getNumAtoms() == 3);
    CHECK(m->getAtomWithIdx(0)->getProp<std::string>(
              common_properties::atomLabel) == "Q_e");
    CHECK(m->getAtomWithIdx(1)->getProp<std::string>(
              common_properties::atomLabel) == "QH_p");
    CHECK(!m->getAtomWithIdx(0)->hasProp(common_properties::dummyLabel));
    CHECK(!m->getAtomWithIdx(1)->hasProp(common_properties::dummyLabel));
    CHECK(!m->getAtomWithIdx(2)->hasProp(common_properties::atomLabel));
    CHECK(m->getAtomWithIdx(0)->hasQuery());
    CHECK(m->getAtomWithIdx(1)->hasQuery());
    CHECK(!m->getAtomWithIdx(2)->hasQuery());

    delete m;
  }
  {  // query properties2
    std::string smiles = "** |$;AH_p;$|";
    SmilesParserParams params;
    params.allowCXSMILES = true;
    ROMol *m = SmilesToMol(smiles, params);
    REQUIRE(m);
    CHECK(m->getNumAtoms() == 2);
    CHECK(m->getAtomWithIdx(1)->getProp<std::string>(
              common_properties::atomLabel) == "AH_p");
    CHECK(!m->getAtomWithIdx(0)->hasProp(common_properties::atomLabel));
    CHECK(m->getAtomWithIdx(0)->hasQuery());
    CHECK(m->getAtomWithIdx(0)->getQuery()->getDescription() ==
          "AtomAtomicNum");
    CHECK(m->getAtomWithIdx(1)->hasQuery());
    CHECK(m->getAtomWithIdx(1)->getQuery()->getDescription() == "AtomNull");

    delete m;
  }

  {  // query properties3
    std::string smiles = "** |$;XH_p;$|";
    SmilesParserParams params;
    params.allowCXSMILES = true;
    ROMol *m = SmilesToMol(smiles, params);
    REQUIRE(m);
    CHECK(m->getNumAtoms() == 2);
    CHECK(m->getAtomWithIdx(1)->getProp<std::string>(
              common_properties::atomLabel) == "XH_p");
    CHECK(!m->getAtomWithIdx(0)->hasProp(common_properties::atomLabel));
    CHECK(m->getAtomWithIdx(0)->hasQuery());
    CHECK(m->getAtomWithIdx(0)->getQuery()->getDescription() ==
          "AtomAtomicNum");
    CHECK(m->getAtomWithIdx(1)->hasQuery());
    CHECK(m->getAtomWithIdx(1)->getQuery()->getDescription() == "AtomOr");

    delete m;
  }
  {  // query properties3
    std::string smiles = "** |$MH_p;M_p;$|";
    SmilesParserParams params;
    params.allowCXSMILES = true;
    ROMol *m = SmilesToMol(smiles, params);
    REQUIRE(m);
    CHECK(m->getNumAtoms() == 2);
    CHECK(m->getAtomWithIdx(0)->getProp<std::string>(
              common_properties::atomLabel) == "MH_p");
    CHECK(m->getAtomWithIdx(1)->getProp<std::string>(
              common_properties::atomLabel) == "M_p");
    CHECK(m->getAtomWithIdx(0)->hasQuery());
    CHECK(m->getAtomWithIdx(0)->getQuery()->getDescription() == "AtomOr");
    CHECK(m->getAtomWithIdx(1)->hasQuery());
    CHECK(m->getAtomWithIdx(1)->getQuery()->getDescription() == "AtomOr");

    delete m;
  }
}

TEST_CASE("CXSMILES and mol name") {
  {
    std::string smiles = "CCC |$foo;;bar$|";
    SmilesParserParams params;
    params.allowCXSMILES = true;
    params.parseName = true;
    ROMol *m = SmilesToMol(smiles, params);
    REQUIRE(m);
    CHECK(m->getNumAtoms() == 3);
    CHECK(m->getAtomWithIdx(0)->getProp<std::string>(
              common_properties::atomLabel) == "foo");
    CHECK(m->getProp<std::string>("_CXSMILES_Data") == "|$foo;;bar$|");
    CHECK(!m->hasProp("_Name"));
    delete m;
  }
  {
    std::string smiles = "CCC |$foo;;bar$| ourname";
    SmilesParserParams params;
    params.allowCXSMILES = true;
    params.parseName = true;

    ROMol *m = SmilesToMol(smiles, params);
    REQUIRE(m);
    CHECK(m->getNumAtoms() == 3);
    CHECK(m->getAtomWithIdx(0)->getProp<std::string>(
              common_properties::atomLabel) == "foo");
    CHECK(m->getProp<std::string>("_CXSMILES_Data") == "|$foo;;bar$|");
    CHECK(m->getProp<std::string>(common_properties::_Name) == "ourname");
    delete m;
  }
}

TEST_CASE("coordinate bonds") {
  {
    std::string smiles = "[Fe]1C=C1 |C:1.0,2.2|";
    SmilesParserParams params;
    params.allowCXSMILES = true;
    ROMol *m = SmilesToMol(smiles, params);
    REQUIRE(m);
    CHECK(m->getNumAtoms() == 3);
    CHECK(m->getBondBetweenAtoms(1, 2));
    CHECK(m->getBondBetweenAtoms(1, 2)->getBondType() == Bond::DOUBLE);
    CHECK(m->getBondBetweenAtoms(0, 1));
    CHECK(m->getBondBetweenAtoms(0, 1)->getBondType() == Bond::DATIVE);
    CHECK(m->getBondBetweenAtoms(0, 1)->getBeginAtomIdx() == 1);
    CHECK(m->getBondBetweenAtoms(0, 2));
    CHECK(m->getBondBetweenAtoms(0, 2)->getBondType() == Bond::DATIVE);
    CHECK(m->getBondBetweenAtoms(0, 2)->getBeginAtomIdx() == 2);
    delete m;
  }
  {
    std::string smiles = "C1[Fe]C=1 |C:0.0,2.1|";
    SmilesParserParams params;
    params.allowCXSMILES = true;
    ROMol *m = SmilesToMol(smiles, params);
    REQUIRE(m);
    CHECK(m->getNumAtoms() == 3);
    CHECK(m->getBondBetweenAtoms(0, 2));
    CHECK(m->getBondBetweenAtoms(0, 2)->getBondType() == Bond::DOUBLE);
    CHECK(m->getBondBetweenAtoms(0, 1));
    CHECK(m->getBondBetweenAtoms(0, 1)->getBondType() == Bond::DATIVE);
    CHECK(m->getBondBetweenAtoms(0, 1)->getBeginAtomIdx() == 0);
    CHECK(m->getBondBetweenAtoms(1, 2));
    CHECK(m->getBondBetweenAtoms(1, 2)->getBondType() == Bond::DATIVE);
    CHECK(m->getBondBetweenAtoms(1, 2)->getBeginAtomIdx() == 2);
    delete m;
  }
}

TEST_CASE("radicals") {
  {
    std::string smiles = "[O]C[O] |^1:0,2|";
    SmilesParserParams params;
    params.allowCXSMILES = true;
    ROMol *m = SmilesToMol(smiles, params);
    REQUIRE(m);
    CHECK(m->getNumAtoms() == 3);
    CHECK(m->getAtomWithIdx(0)->getNumRadicalElectrons() == 1);
    CHECK(m->getAtomWithIdx(1)->getNumRadicalElectrons() == 0);
    CHECK(m->getAtomWithIdx(2)->getNumRadicalElectrons() == 1);

    delete m;
  }
  {
    std::string smiles = "[O][C][O] |^1:0,2,^4:1|";
    SmilesParserParams params;
    params.allowCXSMILES = true;
    ROMol *m = SmilesToMol(smiles, params);
    REQUIRE(m);
    CHECK(m->getNumAtoms() == 3);
    CHECK(m->getAtomWithIdx(0)->getNumRadicalElectrons() == 1);
    CHECK(m->getAtomWithIdx(1)->getNumRadicalElectrons() == 2);
    CHECK(m->getAtomWithIdx(2)->getNumRadicalElectrons() == 1);

    delete m;
  }
  {  // radicals and coordinate bonds
    std::string smiles = "[Fe]N([O])[O] |^1:2,3,C:1.0|";
    SmilesParserParams params;
    params.allowCXSMILES = true;
    ROMol *m = SmilesToMol(smiles, params);
    REQUIRE(m);
    CHECK(m->getNumAtoms() == 4);
    CHECK(m->getAtomWithIdx(1)->getNumRadicalElectrons() == 0);
    CHECK(m->getAtomWithIdx(2)->getNumRadicalElectrons() == 1);
    CHECK(m->getAtomWithIdx(3)->getNumRadicalElectrons() == 1);
    CHECK(m->getBondBetweenAtoms(0, 1));
    CHECK(m->getBondBetweenAtoms(0, 1)->getBondType() == Bond::DATIVE);
    CHECK(m->getBondBetweenAtoms(0, 1)->getBeginAtomIdx() == 1);

    delete m;
  }
}

TEST_CASE("atom values") {
  {  // testing atom values
    std::string smiles =
        "CCC1=CC=CC=C1 |$_AV:value 2;&#59;value1;value "
        "5&#59;6;;;;;$,c:4,6,t:2|";
    SmilesParserParams params;
    params.allowCXSMILES = true;
    ROMol *m = SmilesToMol(smiles, params);
    REQUIRE(m);
    CHECK(m->getNumAtoms() == 8);
    CHECK(m->getAtomWithIdx(0)->hasProp(common_properties::molFileValue));
    CHECK(m->getAtomWithIdx(0)->getProp<std::string>(
              common_properties::molFileValue) == "value 2");

    CHECK(m->getAtomWithIdx(1)->hasProp(common_properties::molFileValue));
    CHECK(m->getAtomWithIdx(1)->getProp<std::string>(
              common_properties::molFileValue) == ";value1");

    CHECK(m->getAtomWithIdx(2)->hasProp(common_properties::molFileValue));
    CHECK(m->getAtomWithIdx(2)->getProp<std::string>(
              common_properties::molFileValue) == "value 5;6");

    delete m;
  }
}

TEST_CASE("atom properties") {
  {  // testing atom properties
    std::string smiles =
        "C1CN1 "
        "|atomProp:0.prop2.val2:0.prop1.val1:1.prop2.v2&#38;4:1.prop1.v1;2;3|";
    SmilesParserParams params;
    params.allowCXSMILES = true;
    ROMol *m = SmilesToMol(smiles, params);
    REQUIRE(m);
    CHECK(m->getNumAtoms() == 3);
    CHECK(m->getAtomWithIdx(0)->hasProp("prop1"));
    CHECK(m->getAtomWithIdx(0)->getProp<std::string>("prop1") == "val1");
    CHECK(m->getAtomWithIdx(0)->hasProp("prop2"));
    CHECK(m->getAtomWithIdx(0)->getProp<std::string>("prop2") == "val2");
    CHECK(m->getAtomWithIdx(1)->hasProp("prop2"));
    CHECK(m->getAtomWithIdx(1)->getProp<std::string>("prop2") == "v2&4");
    CHECK(m->getAtomWithIdx(1)->hasProp("prop1"));
    CHECK(m->getAtomWithIdx(1)->getProp<std::string>("prop1") == "v1;2;3");

    delete m;
  }

  {  // testing atom properties + values
    std::string smiles =
        "C1CN1 "
        "|atomProp:0.prop2.val2:1.prop1.v1;2;3,$_AV:value 2;&#59;value1;$|";
    SmilesParserParams params;
    params.allowCXSMILES = true;
    ROMol *m = SmilesToMol(smiles, params);
    REQUIRE(m);
    CHECK(m->getNumAtoms() == 3);
    CHECK(m->getAtomWithIdx(0)->hasProp("prop2"));
    CHECK(m->getAtomWithIdx(0)->getProp<std::string>("prop2") == "val2");
    CHECK(m->getAtomWithIdx(1)->hasProp("prop1"));
    CHECK(m->getAtomWithIdx(1)->getProp<std::string>("prop1") == "v1;2;3");
    CHECK(m->getAtomWithIdx(0)->hasProp(common_properties::molFileValue));
    CHECK(m->getAtomWithIdx(0)->getProp<std::string>(
              common_properties::molFileValue) == "value 2");

    CHECK(m->getAtomWithIdx(1)->hasProp(common_properties::molFileValue));
    CHECK(m->getAtomWithIdx(1)->getProp<std::string>(
              common_properties::molFileValue) == ";value1");

    delete m;
  }
}

TEST_CASE("Github1968: CXSMILES should be parsed before H removal") {
  {  // the original report
    std::string smiles = "[H]C* |$;;X$|";
    SmilesParserParams params;
    params.allowCXSMILES = true;
    ROMol *m = SmilesToMol(smiles, params);
    REQUIRE(m);
    CHECK(m->getNumAtoms() == 2);
    CHECK(m->getAtomWithIdx(1)->hasProp(common_properties::atomLabel));
    CHECK(m->getAtomWithIdx(1)->getProp<std::string>(
              common_properties::atomLabel) == "X");
    CHECK(!m->getAtomWithIdx(0)->hasProp(common_properties::atomLabel));
    delete m;
  }
  {
    std::string smiles = "C([H])* |$;Y;X$|";
    SmilesParserParams params;
    params.allowCXSMILES = true;
    ROMol *m = SmilesToMol(smiles, params);
    REQUIRE(m);
    CHECK(m->getNumAtoms() == 2);
    CHECK(m->getAtomWithIdx(1)->hasProp(common_properties::atomLabel));
    CHECK(m->getAtomWithIdx(1)->getProp<std::string>(
              common_properties::atomLabel) == "X");
    CHECK(!m->getAtomWithIdx(0)->hasProp(common_properties::atomLabel));
    delete m;
  }
}

TEST_CASE("enhanced stereo") {
  std::vector<unsigned int> atom_ref1({4, 5});
  {
    std::string smiles = "C[C@H](F)[C@H](C)[C@@H](C)Br |a:1,o1:3,5|";
    SmilesParserParams params;
    params.allowCXSMILES = true;
    ROMol *m = SmilesToMol(smiles, params);
    REQUIRE(m);
    CHECK(m->getNumAtoms() == 8);

    auto &stereo_groups = m->getStereoGroups();

    CHECK(stereo_groups.size() == 2);

    auto stg = stereo_groups.begin();
    CHECK(stg->getGroupType() == StereoGroupType::STEREO_ABSOLUTE);
    {
      auto &atoms = stg->getAtoms();
      CHECK(atoms.size() == 1);
      CHECK(atoms[0]->getIdx() == 1);
    }
    ++stg;
    CHECK(stg->getGroupType() == StereoGroupType::STEREO_OR);
    {
      auto &atoms = stg->getAtoms();
      CHECK(atoms.size() == 2);
      CHECK(atoms[0]->getIdx() == 3);
      CHECK(atoms[1]->getIdx() == 5);
    }
    delete m;
  }
  {
    std::string smiles = "C[C@H](F)[C@H](C)[C@@H](C)Br |&1:3,5,a:1|";
    SmilesParserParams params;
    params.allowCXSMILES = true;
    ROMol *m = SmilesToMol(smiles, params);
    REQUIRE(m);
    CHECK(m->getNumAtoms() == 8);

    auto &stereo_groups = m->getStereoGroups();

    CHECK(stereo_groups.size() == 2);

    auto stg = stereo_groups.begin();
    CHECK(stg->getGroupType() == StereoGroupType::STEREO_AND);
    {
      auto &atoms = stg->getAtoms();
      CHECK(atoms.size() == 2);
      CHECK(atoms[0]->getIdx() == 3);
      CHECK(atoms[1]->getIdx() == 5);
    }
    ++stg;
    CHECK(stg->getGroupType() == StereoGroupType::STEREO_ABSOLUTE);
    {
      auto &atoms = stg->getAtoms();
      CHECK(atoms.size() == 1);
      CHECK(atoms[0]->getIdx() == 1);
    }
    delete m;
  }
}

TEST_CASE("HTML char codes") {
  {
    std::string smiles = R"(CCCC* |$;;;;_AP1$,Sg:n:2:2&#44;6-7:ht|)";
    SmilesParserParams params;
    params.allowCXSMILES = true;

    ROMol *m = SmilesToMol(smiles, params);
    REQUIRE(m);

    CHECK(m->getNumAtoms() == 5);

    delete m;
  }
}

TEST_CASE("errors in CXSMILES") {
  {
    std::string smiles = R"(CC |failure)";
    SmilesParserParams params;

    ROMol *m = nullptr;
    try {
      m = SmilesToMol(smiles, params);
    } catch (const SmilesParseException &) {
    }
    CHECK(!m);

    params.strictCXSMILES = false;
    m = SmilesToMol(smiles, params);
    REQUIRE(m);
    CHECK(m->getNumAtoms() == 2);

    delete m;
  }

  {  // sure partial parsing also works
    std::string smiles = "[O][C][O] |^1:0,2,^4:1 FAILURE|";
    SmilesParserParams params;
    params.strictCXSMILES = false;
    ROMol *m = SmilesToMol(smiles, params);
    REQUIRE(m);
    CHECK(m->getNumAtoms() == 3);
    CHECK(m->getAtomWithIdx(0)->getNumRadicalElectrons() == 1);
    CHECK(m->getAtomWithIdx(1)->getNumRadicalElectrons() == 2);
    CHECK(m->getAtomWithIdx(2)->getNumRadicalElectrons() == 1);
    delete m;
  }
}

TEST_CASE("MDL queries") {
  {  // just ring bonds
    auto m =
        "[#6]-[#6]-1-[#6]-[#6]-1 "
        "|rb:0:0,1:*,2:2|"_smiles;
    REQUIRE(m);
    auto sma = MolToSmarts(*m);
    CHECK(sma == "[#6&x0]-[#6&x2]1-[#6&x2]-[#6]-1");
  }

  {  // unsaturation
    auto m =
        "[#6]-[#6]-1-[#6]-[#6]-1 "
        "|u:0,2|"_smiles;
    REQUIRE(m);
    auto sma = MolToSmarts(*m);
    CHECK(sma == "[#6&$(*=,:,#*)]-[#6]1-[#6&$(*=,:,#*)]-[#6]-1");
  }

  {  // substitution count
    auto m =
        "[#6]-[#6]-1-[#6]-[#6]-1 "
        "|s:3:*,1:3|"_smiles;
    REQUIRE(m);
    auto sma = MolToSmarts(*m);
    CHECK(sma == "[#6]-[#6&d3]1-[#6]-[#6&d2]-1");
  }

  {  // everything together
    auto m =
        "[#6]-[#6]-1-[#6]-[#6]-1 "
        "|rb:0:0,1:*,2:2,s:3:*,u:0|"_smiles;
    REQUIRE(m);
    auto sma = MolToSmarts(*m);
    CHECK(sma == "[#6&x0&$(*=,:,#*)]-[#6&x2]1-[#6&x2]-[#6&d2]-1");
  }
}

TEST_CASE("LINKNODES") {
  {
    auto m = "OC1CCC(F)C1 |LN:1:1.3.2.6|"_smiles;
    REQUIRE(m);
    std::string lns;
    CHECK(m->getPropIfPresent(common_properties::molFileLinkNodes, lns));
    CHECK(lns == "1 3 2 2 3 2 7");
  }
  {
    auto m = "OC1CCC(F)C1 |LN:1:1.3.2.6,4:1.4.3.6|"_smiles;
    REQUIRE(m);
    std::string lns;
    CHECK(m->getPropIfPresent(common_properties::molFileLinkNodes, lns));
    CHECK(lns == "1 3 2 2 3 2 7|1 4 2 5 4 5 7");
  }
  {  // linknodes with implicit outer atoms
    auto m = "OC1CCCC1 |LN:4:1.3|"_smiles;
    REQUIRE(m);
    std::string lns;
    CHECK(m->getPropIfPresent(common_properties::molFileLinkNodes, lns));
    CHECK(lns == "1 3 2 5 4 5 6");
  }
  {  // linknodes with implicit outer atoms : fails because atom is
     // three-connected
    bool ok = false;
    try {
      auto m = "OC1CCC(F)C1 |LN:1:1.3|"_smiles;
    } catch (const RDKit::SmilesParseException &) {
      ok = true;
    }
    CHECK(ok);
  }
}

TEST_CASE("variable attachment bonds") {
  {
    auto m = "CO*.C1=CC=NC=C1 |m:2:3.5.4|"_smiles;
    REQUIRE(m);
    const auto bnd = m->getBondBetweenAtoms(1, 2);
    REQUIRE(bnd);
    CHECK(bnd->hasProp(common_properties::_MolFileBondAttach));
    CHECK(bnd->getProp<std::string>(common_properties::_MolFileBondAttach) ==
          "ANY");
    CHECK(bnd->hasProp(common_properties::_MolFileBondEndPts));
    CHECK(bnd->getProp<std::string>(common_properties::_MolFileBondEndPts) ==
          "(3 4 6 5)");
  }

  {
    auto m = "F*.Cl*.C1=CC=NC=C1 |m:1:9.8,3:4.5|"_smiles;
    REQUIRE(m);
    {
      const auto bnd = m->getBondBetweenAtoms(0, 1);
      REQUIRE(bnd);
      CHECK(bnd->hasProp(common_properties::_MolFileBondAttach));
      CHECK(bnd->getProp<std::string>(common_properties::_MolFileBondAttach) ==
            "ANY");
      CHECK(bnd->hasProp(common_properties::_MolFileBondEndPts));
      CHECK(bnd->getProp<std::string>(common_properties::_MolFileBondEndPts) ==
            "(2 10 9)");
    }
    {
      const auto bnd = m->getBondBetweenAtoms(2, 3);
      REQUIRE(bnd);
      CHECK(bnd->hasProp(common_properties::_MolFileBondAttach));
      CHECK(bnd->getProp<std::string>(common_properties::_MolFileBondAttach) ==
            "ANY");
      CHECK(bnd->hasProp(common_properties::_MolFileBondEndPts));
      CHECK(bnd->getProp<std::string>(common_properties::_MolFileBondEndPts) ==
            "(2 5 6)");
    }
  }
}

TEST_CASE("github #6050: stereogroups not combined") {
  SECTION("basics") {
    auto m =
        "C[C@@H](O)[C@H](C)[C@@H](C)[C@@H](C)O |&3:3,o1:7,&2:1,&3:5,r|"_smiles;
    REQUIRE(m);
    CHECK(m->getStereoGroups().size() == 3);
  }
  SECTION("duplicate indices") {
    auto m =
        "C[C@@H](O)[C@H](C)[C@@H](C)[C@@H](C)O |&3:3,o3:7,&2:1,&3:5,r|"_smiles;
    REQUIRE(m);
    CHECK(m->getStereoGroups().size() == 3);
    CHECK(m->getStereoGroups()[0].getGroupType() ==
          StereoGroupType::STEREO_AND);
    CHECK(m->getStereoGroups()[0].getAtoms().size() == 2);
    CHECK(m->getStereoGroups()[1].getGroupType() == StereoGroupType::STEREO_OR);
    CHECK(m->getStereoGroups()[1].getAtoms().size() == 1);
  }
  SECTION("multiple repeats") {
    auto m =
        "C[C@@H](O)[C@H](C)[C@@H](C)[C@H](O)[C@@H](C)[C@H](C)[C@H](C)O |o1:7,&2:1,&3:3,5,o1:9,11,o1:13,r|"_smiles;
    REQUIRE(m);
    CHECK(m->getStereoGroups().size() == 3);
    CHECK(m->getStereoGroups()[0].getGroupType() == StereoGroupType::STEREO_OR);
    CHECK(m->getStereoGroups()[0].getAtoms().size() == 4);
  }
}

class SmilesTest {
 public:
  std::string fileName;
  bool expectedResult;
  unsigned int atomCount;
  unsigned int bondCount;

  SmilesTest(std::string fileNameInit, bool expectedResultInit,
             int atomCountInit, int bondCountInit)
      : fileName(fileNameInit),
        expectedResult(expectedResultInit),
        atomCount(atomCountInit),
        bondCount(bondCountInit) {};

  bool isRxnTest() const { return false; }
};

std::string getExpectedValue(std::string expectedFileName) {
  std::stringstream expectedMolStr;
  std::ifstream in;
  in.open(expectedFileName);
  expectedMolStr << in.rdbuf();
  return expectedMolStr.str();
}

void generateNewExpectedFilesIfSoSpecified(std::string filename,
                                           std::string dataToWrite) {
  if (GenerateExpectedFiles) {
    std::ofstream out;
    out.open(filename);
    out << dataToWrite;
  }
}

void testOneAtropisomers(const SmilesTest *smilesTest) {
  std::string rdbase = getenv("RDBASE");
  std::string fName =
      rdbase + "/Code/GraphMol/SmilesParse/test_data/" + smilesTest->fileName;
  std::string inputSmiles;

  std::stringstream inputSmilesStr;
  std::ifstream inStr;
  inStr.open(fName);
  inputSmilesStr << inStr.rdbuf();
  inputSmiles = inputSmilesStr.str();

  try {
    INFO(fName);

    SmilesParserParams smilesParserParams;
    smilesParserParams.sanitize = true;
    smilesParserParams.removeHs = false;

    std::unique_ptr<ROMol> smilesMol(
        SmilesToMol(inputSmiles, smilesParserParams));

    REQUIRE(smilesMol);
    CHECK(smilesMol->getNumAtoms() == smilesTest->atomCount);
    CHECK(smilesMol->getNumBonds() == smilesTest->bondCount);

    // test round trip back to smiles
    {
      std::string expectedFileName = fName + ".expected.cxsmi";
      SmilesWriteParams ps;
      ps.canonical = false;
      ps.doIsomericSmiles = true;

      unsigned int flags = SmilesWrite::CXSmilesFields::CX_COORDS |
                           SmilesWrite::CXSmilesFields::CX_MOLFILE_VALUES |
                           SmilesWrite::CXSmilesFields::CX_ATOM_PROPS |
                           SmilesWrite::CXSmilesFields::CX_BOND_CFG |
                           SmilesWrite::CXSmilesFields::CX_ENHANCEDSTEREO
          //| SmilesWrite::CXSmilesFields::CX_ALL
          ;

      std::string smilesOut =
          MolToCXSmiles(*smilesMol, ps, flags, RestoreBondDirOptionTrue);

      generateNewExpectedFilesIfSoSpecified(fName + ".NEW.cxsmi", smilesOut);
      CHECK(getExpectedValue(expectedFileName) == smilesOut);
    }

    // second pass without using original wedges

    smilesMol =
        std::unique_ptr<ROMol>(SmilesToMol(inputSmiles, smilesParserParams));

    // test round trip back to smiles
    {
      std::string expectedFileName = fName + ".expected2.cxsmi";

      SmilesWriteParams ps;
      ps.canonical = false;
      ps.doIsomericSmiles = true;

      unsigned int flags = SmilesWrite::CXSmilesFields::CX_COORDS |
                           SmilesWrite::CXSmilesFields::CX_MOLFILE_VALUES |
                           SmilesWrite::CXSmilesFields::CX_ATOM_PROPS |
                           SmilesWrite::CXSmilesFields::CX_BOND_CFG |
                           SmilesWrite::CXSmilesFields::CX_ENHANCEDSTEREO;

      std::string smilesOut =
          MolToCXSmiles(*smilesMol, ps, flags, RestoreBondDirOptionClear);

      generateNewExpectedFilesIfSoSpecified(fName + ".NEW2.cxsmi", smilesOut);
      CHECK(getExpectedValue(expectedFileName) == smilesOut);
    }

    // third pass without using original wedges and with canonicalization

    smilesMol =
        std::unique_ptr<ROMol>(SmilesToMol(inputSmiles, smilesParserParams));

    // test round trip back to smiles
    {
      std::string expectedFileName = fName + ".expected3.cxsmi";

      SmilesWriteParams ps;
      ps.canonical = true;
      ps.doIsomericSmiles = true;

      unsigned int flags = SmilesWrite::CXSmilesFields::CX_COORDS |
                           SmilesWrite::CXSmilesFields::CX_MOLFILE_VALUES |
                           SmilesWrite::CXSmilesFields::CX_ATOM_PROPS |
                           SmilesWrite::CXSmilesFields::CX_BOND_CFG |
                           SmilesWrite::CXSmilesFields::CX_ENHANCEDSTEREO;

      std::string smilesOut =
          MolToCXSmiles(*smilesMol, ps, flags, RestoreBondDirOptionClear);

      generateNewExpectedFilesIfSoSpecified(fName + ".NEW3.cxsmi", smilesOut);
      auto expected = getExpectedValue(expectedFileName);
      CHECK(expected == smilesOut);
    }

    smilesMol =
        std::unique_ptr<RWMol>(SmilesToMol(inputSmiles, smilesParserParams));
    {
      std::string expectedFileName = fName + ".expected.sdf";
      std::string outMolStr = "";
      try {
        outMolStr = MolToMolBlock(*smilesMol, true, 0, true, true);
      } catch (const RDKit::KekulizeException &e) {
        outMolStr = "";
      } catch (...) {
        throw;  // re-throw the error if not a kekule error
      }
      if (outMolStr == "") {
        outMolStr = MolToMolBlock(*smilesMol, true, 0, false,
                                  true);  // try without kekule'ing
      }
      generateNewExpectedFilesIfSoSpecified(fName + ".NEW.sdf", outMolStr);
      CHECK(getExpectedValue(expectedFileName) == outMolStr);
    }
    smilesMol =
        std::unique_ptr<RWMol>(SmilesToMol(inputSmiles, smilesParserParams));
    {
      std::string mrvBlock;
      std::string expectedFileName = fName + ".expected.mrv";
      std::string outMolStr = "";
      try {
        RDKit::Chirality::reapplyMolBlockWedging(*smilesMol);
        outMolStr = MolToMrvBlock(*smilesMol, true, -1, true, false);
      } catch (const RDKit::KekulizeException &e) {
        outMolStr = "";
      } catch (...) {
        throw;  // re-throw the error if not a kekule error
      }
      if (outMolStr == "") {
        RDKit::Chirality::reapplyMolBlockWedging(*smilesMol);
        outMolStr = MolToMrvBlock(*smilesMol, true, -1, false,
                                  false);  // try without kekule'ing
      }

      generateNewExpectedFilesIfSoSpecified(fName + ".NEW.mrv", outMolStr);
      CHECK(getExpectedValue(expectedFileName) == outMolStr);
    }
    BOOST_LOG(rdInfoLog) << "done" << std::endl;
  } catch (const std::exception &e) {
    if (smilesTest->expectedResult != false) {
      throw;
    }
    return;
  }

  CHECK(smilesTest->expectedResult == true);
}

void testOneAtropisomersCanon(const SmilesTest *smilesTest) {
  std::string rdbase = getenv("RDBASE");
  std::string fName =
      rdbase + "/Code/GraphMol/SmilesParse/test_data/" + smilesTest->fileName;
  std::string inputSmiles;

  std::stringstream inputSmilesStr;
  std::ifstream inStr;
  inStr.open(fName);
  inputSmilesStr << inStr.rdbuf();
  inputSmiles = inputSmilesStr.str();

  try {
    SmilesParserParams smilesParserParams;
    smilesParserParams.sanitize = true;
    smilesParserParams.removeHs = false;

    std::unique_ptr<ROMol> smilesMol(
        SmilesToMol(inputSmiles, smilesParserParams));

    REQUIRE(smilesMol);
    CHECK(smilesMol->getNumAtoms() == smilesTest->atomCount);
    CHECK(smilesMol->getNumBonds() == smilesTest->bondCount);

    // test kekule and canonicalization
    {
      RDKit::canonicalizeStereoGroups(smilesMol);

      std::string expectedMrvName = fName + ".kekule_expected.cxsmi";
      SmilesWriteParams ps;
      ps.canonical = true;
      ps.doKekule = true;
      ps.doIsomericSmiles = true;

      unsigned int flags = SmilesWrite::CXSmilesFields::CX_COORDS |
                           SmilesWrite::CXSmilesFields::CX_MOLFILE_VALUES |
                           SmilesWrite::CXSmilesFields::CX_ATOM_PROPS |
                           SmilesWrite::CXSmilesFields::CX_BOND_CFG |
                           SmilesWrite::CXSmilesFields::CX_ENHANCEDSTEREO
          //| SmilesWrite::CXSmilesFields::CX_ALL
          ;

      std::string smilesOut =
          MolToCXSmiles(*smilesMol, ps, flags, RestoreBondDirOptionTrue);

      generateNewExpectedFilesIfSoSpecified(fName + ".kekule_NEW.cxsmi",
                                            smilesOut);
      CHECK(getExpectedValue(expectedMrvName) == smilesOut);
    }

    // test aromatic and canonicalization

    smilesMol =
        std::unique_ptr<RWMol>(SmilesToMol(inputSmiles, smilesParserParams));

    RDKit::canonicalizeStereoGroups(smilesMol);

    // test round trip back to smiles
    {
      std::string expectedMrvName = fName + ".arom_expected.cxsmi";

      SmilesWriteParams ps;
      ps.canonical = true;
      ps.doKekule = false;
      ps.doIsomericSmiles = true;

      unsigned int flags = SmilesWrite::CXSmilesFields::CX_COORDS |
                           SmilesWrite::CXSmilesFields::CX_MOLFILE_VALUES |
                           SmilesWrite::CXSmilesFields::CX_ATOM_PROPS |
                           SmilesWrite::CXSmilesFields::CX_BOND_CFG |
                           SmilesWrite::CXSmilesFields::CX_ENHANCEDSTEREO;

      std::string smilesOut =
          MolToCXSmiles(*smilesMol, ps, flags, RestoreBondDirOptionClear);

      generateNewExpectedFilesIfSoSpecified(fName + ".arom_NEW.cxsmi",
                                            smilesOut);
      CHECK(getExpectedValue(expectedMrvName) == smilesOut);
    }

    BOOST_LOG(rdInfoLog) << "done" << std::endl;
  } catch (const std::exception &e) {
    if (smilesTest->expectedResult != false) {
      throw;
    }
    return;
  }

  CHECK(smilesTest->expectedResult == true);
}

void testOne3dChiral(const SmilesTest *smilesTest) {
  std::string rdbase = getenv("RDBASE");
  std::string fName =
      rdbase + "/Code/GraphMol/SmilesParse/test_data/" + smilesTest->fileName;
  std::string inputSmiles;

  std::stringstream inputSmilesStr;
  std::ifstream inStr;
  inStr.open(fName);
  inputSmilesStr << inStr.rdbuf();
  inputSmiles = inputSmilesStr.str();

  try {
    SmilesParserParams smilesParserParams;
    smilesParserParams.sanitize = false;
    smilesParserParams.removeHs = false;

    std::unique_ptr<RWMol> smilesMol(
        SmilesToMol(inputSmiles, smilesParserParams));

    REQUIRE(smilesMol);
    CHECK(smilesMol->getNumAtoms() == smilesTest->atomCount);
    CHECK(smilesMol->getNumBonds() == smilesTest->bondCount);

    // test round trip back to smiles
    {
      std::string expectedFileName = fName + ".expected3D.cxsmi";
      SmilesWriteParams ps;
      ps.canonical = false;
      ps.doIsomericSmiles = true;

      unsigned int flags = SmilesWrite::CXSmilesFields::CX_COORDS |
                           SmilesWrite::CXSmilesFields::CX_MOLFILE_VALUES |
                           SmilesWrite::CXSmilesFields::CX_ATOM_PROPS |
                           SmilesWrite::CXSmilesFields::CX_BOND_CFG |
                           SmilesWrite::CXSmilesFields::CX_ENHANCEDSTEREO
          //| SmilesWrite::CXSmilesFields::CX_ALL
          ;

      std::string smilesOut =
          MolToCXSmiles(*smilesMol, ps, flags, RestoreBondDirOptionTrue);

      generateNewExpectedFilesIfSoSpecified(fName + ".NEW3D.cxsmi", smilesOut);
      CHECK(getExpectedValue(expectedFileName) == smilesOut);
    }

    // second pass use onlyExplicit3D

    smilesParserParams.sanitize = true;
    smilesMol =
        std::unique_ptr<RWMol>(SmilesToMol(inputSmiles, smilesParserParams));
    RDKit::Chirality::removeNonExplicit3DChirality(*smilesMol);

    // test no canonical, sanitize,  no restore bond dirs
    {
      std::string expectedFileName = fName + ".expected3D2.cxsmi";

      SmilesWriteParams ps;
      ps.canonical = false;
      ps.doIsomericSmiles = true;

      unsigned int flags = SmilesWrite::CXSmilesFields::CX_COORDS |
                           SmilesWrite::CXSmilesFields::CX_MOLFILE_VALUES |
                           SmilesWrite::CXSmilesFields::CX_ATOM_PROPS |
                           SmilesWrite::CXSmilesFields::CX_BOND_CFG |
                           SmilesWrite::CXSmilesFields::CX_ENHANCEDSTEREO;

      std::string smilesOut =
          MolToCXSmiles(*smilesMol, ps, flags, RestoreBondDirOptionClear);

      generateNewExpectedFilesIfSoSpecified(fName + ".NEW3D2.cxsmi", smilesOut);
      CHECK(getExpectedValue(expectedFileName) == smilesOut);
    }

    BOOST_LOG(rdInfoLog) << "done" << std::endl;
  } catch (const std::exception &e) {
    if (smilesTest->expectedResult != false) {
      throw;
    }
    return;
  }

  CHECK(smilesTest->expectedResult == true);
}

TEST_CASE("testAtropisomersInCXSmiles") {
  {
    std::list<SmilesTest> smiTests{
        SmilesTest("ShortAtropisomerNoCoords.cxsmi", true, 14, 15),
        SmilesTest("ShortAtropisomer.cxsmi", true, 14, 15),
        SmilesTest("ShortAtropisomerArom.cxsmi", true, 14, 15),
        SmilesTest("AtropManyChirals.cxsmi", true, 20, 20),
        SmilesTest("AtropManyChiralsEnhanced.cxsmi", true, 20, 20),
        SmilesTest("AtropManyChiralsEnhanced2.cxsmi", true, 20, 20),
        SmilesTest("AtropManyChiralsEnhanced3.cxsmi", true, 20, 20),
        SmilesTest("AtropManyChiralsEnhanced4.cxsmi", true, 20, 20),
        SmilesTest("BMS-986142_3d_chiral.cxsmi", true, 72, 77),
        SmilesTest("BMS-986142_3d.cxsmi", true, 72, 77),
        SmilesTest("BMS-986142_atrop1.cxsmi", true, 42, 47),
        SmilesTest("BMS-986142_atrop2.cxsmi", true, 42, 47),
        SmilesTest("BMS-986142_atrop3.cxsmi", true, 42, 47),
        SmilesTest("BMS-986142_atrop4.cxsmi", true, 42, 47),
        SmilesTest("BMS-986142_atrop5.cxsmi", true, 42, 47),
        SmilesTest("BMS-986142_atrop6.cxsmi", true, 42, 47),
        SmilesTest("BMS-986142_atropBad1.cxsmi", true, 42, 47),
        SmilesTest("BMS-986142_atropBad2.cxsmi", true, 42, 47),
        SmilesTest("JDQ443_3d.cxsmi", true, 66, 72),
        SmilesTest("JDQ443_atrop1.cxsmi", true, 38, 44),
        SmilesTest("JDQ443_atrop2.cxsmi", true, 38, 44),
        SmilesTest("JDQ443_atrop3.cxsmi", true, 38, 44),
        SmilesTest("JDQ443_atrop4.cxsmi", true, 38, 44),
        SmilesTest("JDQ443_atropBad1.cxsmi", true, 38, 44),
        SmilesTest("RP-6306_atrop1.cxsmi", true, 24, 26),
        SmilesTest("RP-6306_atrop2.cxsmi", true, 24, 26),
        SmilesTest("RP-6306_atrop3.cxsmi", true, 24, 26),
        SmilesTest("RP-6306_atrop4.cxsmi", true, 24, 26),
        SmilesTest("RP-6306_atrop5.cxsmi", true, 24, 26),
        SmilesTest("RP-6306_atrop6.cxsmi", true, 24, 26),
        SmilesTest("RP-6306_atropBad1.cxsmi", true, 24, 26),
        SmilesTest("RP-6306_atropBad2.cxsmi", true, 24, 26),
        // note the rp-6306_3d.cxsmi is backwards from the 2D versions
        // the 2D version were based on images from drug hunter
        // the 3D version came from PUBCHEM
        SmilesTest("RP-6306_3d.cxsmi", true, 44, 46),
        SmilesTest("Sotorasib_atrop1.cxsmi", true, 41, 45),
        SmilesTest("Sotorasib_atrop2.cxsmi", true, 41, 45),
        SmilesTest("Sotorasib_atrop3.cxsmi", true, 41, 45),
        SmilesTest("Sotorasib_atrop4.cxsmi", true, 41, 45),
        SmilesTest("Sotorasib_atrop5.cxsmi", true, 41, 45),
        SmilesTest("Sotorasib_atropBad1.cxsmi", true, 41, 45),
        SmilesTest("Sotorasib_atropBad2.cxsmi", true, 41, 45),
        // note the sotorasib_3d.cxsmi is backwards from
        //     the 2D versions the 2D version were based on images from drug
        //     hunter the 3D version came from PUBCHEM
        SmilesTest("Sotorasib_3d.cxsmi", true, 71, 75),
        SmilesTest("ZM374979_atrop1.cxsmi", true, 45, 49),
        SmilesTest("ZM374979_atrop2.cxsmi", true, 45, 49),
        SmilesTest("ZM374979_atrop3.cxsmi", true, 45, 49),
        SmilesTest("ZM374979_atrop4.cxsmi", true, 45, 49),
        SmilesTest("ZM374979_atropBad1.cxsmi", true, 45, 49),
        // note the mrtx1719_3d.cxsmi is backwards from the 2D versions
        // the 2D version were based on images from drug hunter
        // the 3D version came from PUBCHEM
        SmilesTest("Mrtx1719_3d.cxsmi", true, 51, 55),
        SmilesTest("Mrtx1719_atrop1.cxsmi", true, 33, 37),
        SmilesTest("Mrtx1719_atrop2.cxsmi", true, 33, 37),
        SmilesTest("Mrtx1719_atrop3.cxsmi", true, 33, 37),
        SmilesTest("Mrtx1719_atrop4.cxsmi", true, 33, 37),
        SmilesTest("Mrtx1719_atropBad1.cxsmi", true, 33, 37),
    };

    for (auto smiTest : smiTests) {
      printf("Test\n\n %s\n\n", smiTest.fileName.c_str());
      // RDDepict::preferCoordGen = true;
      testOneAtropisomers(&smiTest);
    }
  }

  BOOST_LOG(rdInfoLog) << "done" << std::endl;
}

TEST_CASE("testAtropisomersInCXSmilesCanon") {
  {
    std::list<SmilesTest> smiTests{
        SmilesTest("AtropCanon1.cxsmi", true, 15, 16),
        SmilesTest("AtropCanon2.cxsmi", true, 15, 16),
        SmilesTest("AtropCanon3.cxsmi", true, 15, 16),
    };

    for (auto smiTest : smiTests) {
      printf("Test\n\n %s\n\n", smiTest.fileName.c_str());
      testOneAtropisomersCanon(&smiTest);
    }
  }

  BOOST_LOG(rdInfoLog) << "done" << std::endl;
}

TEST_CASE("test3DChiral") {
  std::list<SmilesTest> smiTests{
      // SmilesTest("Cubane.cxsmi", true, 16, 20),
      SmilesTest("BMS-986142_3d_chiral.cxsmi", true, 72, 77),
      SmilesTest("BMS-986142_3d.cxsmi", true, 72, 77),
  };

  for (auto smiTest : smiTests) {
    printf("Test\n\n %s\n\n", smiTest.fileName.c_str());
    // RDDepict::preferCoordGen = true;
    testOne3dChiral(&smiTest);
  }

  BOOST_LOG(rdInfoLog) << "done" << std::endl;
}

void testOneSmilesCanonicalization(std::string smiles,
                                   std::string &expectedStr) {
  SmilesParserParams smilesParserParams;
  smilesParserParams.sanitize = true;
  std::unique_ptr<RWMol> randMol(SmilesToMol(smiles, smilesParserParams));

  // test round trip back to smiles

  SmilesWriteParams ps;
  ps.canonical = true;
  ps.doIsomericSmiles = true;

  std::string smilesOut = MolToSmiles(*randMol, ps);

  if (expectedStr == "") {
    expectedStr = smilesOut;  // if not supplied, use the first one
  }
  CHECK(expectedStr == smilesOut);
}

void testSmilesCanonicalization(std::string smiles,
                                std::string expectedStr = "") {
  BOOST_LOG(rdInfoLog) << "testing smiles canonicalization " << std::endl;

  try {
    testOneSmilesCanonicalization(smiles, expectedStr);

    SmilesParserParams smilesParserParams;
    smilesParserParams.sanitize = true;

    std::unique_ptr<RWMol> smilesMol(SmilesToMol(smiles, smilesParserParams));
    REQUIRE(smilesMol);

    unsigned int randomSeed = 0xf00d;
    auto smiV = MolToRandomSmilesVect(*smilesMol, 100, randomSeed);

    for (auto smi : smiV) {
      testOneSmilesCanonicalization(smi, expectedStr);
    }

    BOOST_LOG(rdInfoLog) << "done" << std::endl;
  } catch (const std::exception &e) {
    CHECK(false);
    return;
  }
}

void testMolCanonicalization(std::string fileName1, std::string fileName2,
                             unsigned int atomIndexToMark1,
                             Atom::ChiralType chiralType1,
                             unsigned int atomIndexToMark2,
                             Atom::ChiralType chiralType2) {
  BOOST_LOG(rdInfoLog) << "testing mol canonicalization " << std::endl;
  std::string rdbase = getenv("RDBASE");
  std::string fName1 =
      rdbase + "/Code/GraphMol/SmilesParse/test_data/" + fileName1;
  std::string fName2 =
      rdbase + "/Code/GraphMol/SmilesParse/test_data/" + fileName2;

  try {
    std::unique_ptr<RWMol> mol1(MolFileToMol(fName1, true, false, false));
    mol1->getAtomWithIdx(atomIndexToMark1)->setChiralTag(chiralType1);

    std::unique_ptr<RWMol> mol2(MolFileToMol(fName2, true, false, false));
    mol2->getAtomWithIdx(atomIndexToMark2)->setChiralTag(chiralType2);
    CHECK(mol1->getNumAtoms() > 0);
    CHECK(mol2->getNumAtoms() > 0);

    auto smilesOut1 = MolToSmiles(*mol1);
    auto smilesOut2 = MolToSmiles(*mol2);

    CHECK(smilesOut1 == smilesOut2);

    BOOST_LOG(rdInfoLog) << "done" << std::endl;
  } catch (const std::exception &e) {
    CHECK(false);
    return;
  }
}

std::vector<std::string> splitOnString(std::string s, const std::string delim) {
  CHECK(s.size() > 0);
  auto delimSize = delim.size();
  CHECK(delimSize > 0);

  std::vector<std::string> res;

  while (s.size() >= delimSize) {
    auto pos = s.find(delim);
    if (pos == std::string::npos) {
      break;
    }
    res.push_back(s.substr(0, pos));
    s.erase(0, pos + delimSize);  // 3 is the length of the delimiter, "%20"
  }

  // if anything is left, add it to the vector
  if (s.size() > 0) {
    res.push_back(s);
  }

  return res;
}
void testMolCanonicalizationAtrop(std::string fileName1,
                                  std::string fileName2) {
  BOOST_LOG(rdInfoLog) << "testing mol canonicalization " << std::endl;
  std::string rdbase = getenv("RDBASE");
  std::string fName1 =
      rdbase + "/Code/GraphMol/SmilesParse/test_data/" + fileName1;
  std::string fName2 =
      rdbase + "/Code/GraphMol/SmilesParse/test_data/" + fileName2;

  try {
    std::unique_ptr<RWMol> mol1(MolFileToMol(fName1, true, false, false));

    std::unique_ptr<RWMol> mol2(MolFileToMol(fName2, true, false, false));
    CHECK(mol1->getNumAtoms() > 0);
    CHECK(mol2->getNumAtoms() > 0);

    SmilesWriteParams ps;
    ps.canonical = true;
    ps.doIsomericSmiles = true;
    unsigned int flags = SmilesWrite::CXSmilesFields::CX_ALL;
    //  unsigned int flags =
    //     SmilesWrite::CXSmilesFields::CX_COORDS |
    //     SmilesWrite::CXSmilesFields::CX_MOLFILE_VALUES |
    //     SmilesWrite::CXSmilesFields::CX_ATOM_PROPS |
    //     SmilesWrite::CXSmilesFields::CX_BOND_CFG |
    //     SmilesWrite::CXSmilesFields::CX_ENHANCEDSTEREO |
    //    ;

    // mol1->clearConformers();

    std::string smilesOut1 =
        MolToCXSmiles(*mol1, ps, flags, RestoreBondDirOptionClear);
    std::string smilesOut2 =
        MolToCXSmiles(*mol2, ps, flags, RestoreBondDirOptionClear);

    std::vector<std::string> parts = splitOnString(smilesOut1, " |");
    CHECK(parts.size() == 2);
    auto smilesOnly1 = parts[0];
    std::vector<std::string> subParts = splitOnString(parts[1], ",),");
    CHECK(subParts.size() == 2);
    auto wedges1 = subParts[1];

    parts = splitOnString(smilesOut2, " |");
    CHECK(parts.size() == 2);
    auto smilesOnly2 = parts[0];
    subParts = splitOnString(parts[1], ",),");
    CHECK(subParts.size() == 2);
    auto wedges2 = subParts[1];

    CHECK(smilesOnly1 == smilesOnly2);
    CHECK(wedges1 == wedges2);

    BOOST_LOG(rdInfoLog) << "done" << std::endl;
  } catch (const std::exception &e) {
    CHECK(false);
    return;
  }
}

TEST_CASE("SMILES CANONICALIZATION ATROP") {
  SECTION("atrop") {
    testMolCanonicalizationAtrop("ST-0023268.mol", "ST-0023267_B.mol");
  }
}

TEST_CASE("SMILES CANONICALIZATION") {
  SECTION("adamantaneError") {
    std::string expectedSmiles =
        R"(C[C@@H](PC(C)(O)O)[C@]12C[C@@]3(F)C[C@@](F)(C[C@](F)(C3)C1)C2)";
    std::string AdamantaneError1 =
        R"(C[C@@H](PC(C)(O)O)[C@]12C[C@@]3(F)C[C@@](F)(C[C@](F)(C3)C1)C2)";
    std::string AdamantaneError2 =
        R"(C[C@@H](PC(C)(O)O)[C@]12C[C@]3(F)C[C@](F)(C[C@](F)(C3)C1)C2)";

    testSmilesCanonicalization(AdamantaneError1, expectedSmiles);
    testSmilesCanonicalization(AdamantaneError2, expectedSmiles);
  }

  SECTION("chiralCopper") {
    testMolCanonicalization("ChiralSpiro.sdf", "ChiralSpiro2.sdf", 4,
                            Atom::CHI_TETRAHEDRAL_CCW, 4,
                            Atom::CHI_TETRAHEDRAL_CCW);
  }

  SECTION("Other Compounds") {
    testSmilesCanonicalization(
        R"(CC1=C(\C=C\C(C)=C\C=C\C(C)=C/C(O)=O)C(C)(C)CCC1)");
    testSmilesCanonicalization("CN1N=C(SC1=NC(C)=O)S(N)(=O)=O |c:2|");
    testSmilesCanonicalization(
        "C[C@@H]1CCCCCCCCC(=O)OCCN[C@H](C)CCCCCCCCC(=O)OCCN[C@H](C)CCCCCCCCC(=O)OCCN1");
    testSmilesCanonicalization("N[C@@H]([O-])c1cc[13c]cc1");

    // this one is expected to fail
    // testSmilesCanonicalizationOldVsNew(
    //     R"(C[C@@H](PC(C)(O)O)[C@]12C[C@@]3(F)C[C@@](F)(C[C@](F)(C3)C1)C2)");

    std::string rdbase = getenv("RDBASE");
    std::string fName =
        rdbase + "/Code/GraphMol/SmilesParse/test_data/TestSmilesUniq.sdf";

    std::ifstream in;
    in.open(fName);
    while (!in.eof()) {
      std::string molBlock = "";
      std::string line;
      while (!in.eof() && line.find("$$$$") == std::string::npos) {
        std::getline(in, line);
        molBlock += line + "\n";
      }

      if (molBlock.length() > 25) {
        std::unique_ptr<RWMol> mol(MolBlockToMol(molBlock));
        std::string smiles = MolToCXSmiles(*mol);

        testSmilesCanonicalization(smiles);
      }
    }
  }
}

TEST_CASE(
    "github #6225: removes enhanced stereo if doIsomericSmiles is false") {
  {  // Gets rid of chiral centers
    std::string smiles = "O[C@H](Br)[C@H](F)C |&1:1,3|";
    ROMol *m = SmilesToMol(smiles);
    SmilesWriteParams params;
    params.doIsomericSmiles = false;
    REQUIRE(m);
    CHECK(MolToCXSmiles(*m, params) == "CC(F)C(O)Br");
    delete m;
  }

  // cis-trans flags
  {
    std::string smiles = "C1CCCC/C=C/CCC1 |ctu:5|";
    ROMol *m = SmilesToMol(smiles);
    SmilesWriteParams params;
    params.doIsomericSmiles = false;
    REQUIRE(m);
    CHECK(MolToCXSmiles(*m, params) == "C1=CCCCCCCCC1");
    delete m;
  }
}

TEST_CASE(
    "Github #6315: MolToSmiles(canonical=False) creates the wrong _smilesBondOutputOrder property") {
  auto m = "C"_smiles;
  REQUIRE(m);

  SECTION("initial report") {
    SmilesWriteParams sw;
    sw.canonical = false;
    auto smi = MolToSmiles(*m, sw);
    CHECK(smi == "C");
    auto cxsmi = MolToCXSmiles(*m, sw);
    CHECK(cxsmi == "C");
  }

  SECTION("details") {
    SmilesWriteParams sw;
    sw.canonical = false;
    auto smi = MolToSmiles(*m, sw);
    CHECK(smi == "C");
    std::vector<unsigned int> order;
    CHECK(
        m->getPropIfPresent(common_properties::_smilesBondOutputOrder, order));
    CHECK(order.empty());
  }

  SECTION("bond ordering is actually correct") {
    auto m2 = "C1(CC1)O"_smiles;
    REQUIRE(m2);

    SmilesWriteParams sw;
    sw.canonical = false;
    auto smi = MolToSmiles(*m2, sw);
    CHECK(smi == "C1(O)CC1");
    std::vector<unsigned int> order;
    CHECK(
        m2->getPropIfPresent(common_properties::_smilesBondOutputOrder, order));
    CHECK(order.size() == 4);
    CHECK(order == std::vector<unsigned int>{2, 0, 1, 3});
  }
}

TEST_CASE("StereoGroup id forwarding", "[StereoGroup][cxsmiles]") {
  std::unique_ptr<ROMol> m =
      "C[C@@H](O)[C@H](C)[C@@H](C)[C@@H](C)O |&7:3,o1:7,&8:1,&9:5|"_smiles;
  REQUIRE(m);
  CHECK(m->getStereoGroups().size() == 4);

  SECTION("ids reassigned by default") {
    const auto smi_out = MolToCXSmiles(*m);
    CHECK(smi_out.find("&1") != std::string::npos);
    CHECK(smi_out.find("&2") != std::string::npos);
    CHECK(smi_out.find("&3") != std::string::npos);
    CHECK(smi_out.find("o1") != std::string::npos);
  }

  SECTION("forward input ids") {
    forwardStereoGroupIds(*m);
    const auto smi_out = MolToCXSmiles(*m);
    CHECK(smi_out.find("&7") != std::string::npos);
    CHECK(smi_out.find("&8") != std::string::npos);
    CHECK(smi_out.find("&9") != std::string::npos);
    CHECK(smi_out.find("o1") != std::string::npos);
  }

  SECTION("forward input ids - rigorous") {
    forwardStereoGroupIds(*m);
    RDKit::canonicalizeStereoGroups(m);
    const auto smi_out = MolToCXSmiles(*m);
    CHECK(smi_out.find("&1") != std::string::npos);
    CHECK(smi_out.find("&2") != std::string::npos);
    CHECK(smi_out.find("&3") != std::string::npos);
    CHECK(smi_out.find("o1") != std::string::npos);
  }
}

TEST_CASE(
    "Github #6309: CXSMILES: atom with labels should not also have dummyLabel property set") {
  SECTION("as-reported") {
    std::vector<std::string> data = {"F* |$;foo_p$|", "F* |$;HAR_p$|"};
    for (const auto &smi : data) {
      INFO(smi);
      std::unique_ptr<RWMol> m{SmilesToMol(smi)};
      REQUIRE(m);
      CHECK(m->getAtomWithIdx(1)->hasProp(common_properties::atomLabel));
      CHECK(!m->getAtomWithIdx(1)->hasProp(common_properties::dummyLabel));
      CHECK(MolToCXSmiles(*m).find("atomProp") == std::string::npos);
    }
  }
}

TEST_CASE("write attachment points") {
  auto m = "C[C@H](N*)C(*)=O"_smiles;
  REQUIRE(m);
  m->getAtomWithIdx(3)->setProp(common_properties::_fromAttachPoint, 1);
  m->getAtomWithIdx(5)->setProp(common_properties::_fromAttachPoint, 2);
  CHECK(MolToCXSmiles(*m) == "*N[C@@H](C)C(*)=O |$_AP1;;;;;_AP2;$|");
}

TEST_CASE("github #7414: CXSmiles writer does not use default conformer ID") {
  SECTION("basics") {
    auto m = "CC |(-0.75,0,;0.75,0,)|"_smiles;
    REQUIRE(m);
    CHECK(m->getNumConformers() == 1);
    m->getConformer().setId(5);
    CHECK(MolToCXSmiles(*m) == "CC |(-0.75,0,;0.75,0,)|");
  }
}

TEST_CASE("Github #7372: SMILES output option to disable dative bonds") {
  SECTION("basics") {
    auto m = "[NH3]->[Fe]-[NH2]"_smiles;
    REQUIRE(m);
    auto smi = MolToCXSmiles(*m);
    CHECK(smi == "[NH2][Fe][NH3] |C:2.1|");

    // disable the dative bond output
    SmilesWriteParams ps;
    smi = MolToCXSmiles(*m, ps,
                        SmilesWrite::CXSmilesFields::CX_ALL_BUT_COORDS ^
                            SmilesWrite::CXSmilesFields::CX_COORDINATE_BONDS);
    CHECK(smi == "[NH2][Fe][NH3]");
  }
  SECTION("basics, SMARTS output") {
    auto m = "[NH3]->[Fe]-[NH2]"_smiles;
    REQUIRE(m);
    auto smi = MolToCXSmarts(*m);
    CHECK(smi == "[#7]-[Fe]-[#7] |C:0.0|");
  }
  SECTION("two dative bonds") {
    auto m = "[NH3][Fe][NH3]"_smiles;  // auto single->dative conversion
    REQUIRE(m);
    auto smi = MolToCXSmiles(*m);
    CHECK(smi == "[NH3][Fe][NH3] |C:0.0,2.1|");
  }
  SECTION("two dative bonds, SMARTS output") {
    auto m = "[NH3][Fe][NH3]"_smiles;  // auto single->dative conversion
    REQUIRE(m);
    auto smi = MolToCXSmarts(*m);
    CHECK(smi == "[#7]-[Fe]-[#7] |C:0.0,2.1|");
  }
}

TEST_CASE(
    "Github #7725: double bond geometry not perceived even though c: or t: are in CXSMILES") {
  SECTION("as reported") {
    auto m = "C/C=C/C1=CC=CC=C1 |c:5,7,t:3|"_smiles;
    REQUIRE(m);
    CHECK((m->getBondWithIdx(1)->getStereo() == Bond::STEREOTRANS ||
           m->getBondWithIdx(1)->getStereo() == Bond::STEREOE));
    CHECK(m->getBondWithIdx(1)->getStereoAtoms() == std::vector<int>{0, 3});
  }
  SECTION("include actual double bond stereo in a ring") {
    auto m = "C/C=C/C1CCCC=CCCCCC1 |t:7|"_smiles;
    CHECK((m->getBondWithIdx(1)->getStereo() == Bond::STEREOTRANS ||
           m->getBondWithIdx(1)->getStereo() == Bond::STEREOE));
    CHECK(m->getBondWithIdx(1)->getStereoAtoms() == std::vector<int>{0, 3});
    CHECK((m->getBondWithIdx(7)->getStereo() == Bond::STEREOTRANS ||
           m->getBondWithIdx(7)->getStereo() == Bond::STEREOE));
    CHECK(m->getBondWithIdx(7)->getStereoAtoms() == std::vector<int>{6, 9});
  }
}

TEST_CASE("cis/trans/unknown in CXSMILES incorrectly interpreted") {
  // This is #8365 and #8364
  UseLegacyStereoPerceptionFixture f(false);
  SECTION("in a ring") {
    {
      {
        auto m = "FC1(=C(F)CCCCCCCCCC1) |c:1|"_smiles;
        REQUIRE(m);
        CHECK(m->getBondWithIdx(1)->getStereo() == Bond::STEREOCIS);
        CHECK(m->getBondWithIdx(1)->getStereoAtoms() == std::vector<int>{0, 3});
      }
      {
        auto m = "C1C(F)=C(F)CCCCCCCCC1 |c:2|"_smiles;
        REQUIRE(m);
        CHECK(m->getBondWithIdx(2)->getStereo() == Bond::STEREOCIS);
        CHECK(m->getBondWithIdx(2)->getStereoAtoms() == std::vector<int>{0, 4});
      }
    }
    {
      auto m = "FC1(=C(F)CCCCCCCCCC1) |t:1|"_smiles;
      REQUIRE(m);
      CHECK(m->getBondWithIdx(1)->getStereo() == Bond::STEREOTRANS);
      CHECK(m->getBondWithIdx(1)->getStereoAtoms() == std::vector<int>{0, 3});
    }
    {
      auto m = "FC1(=C(F)CCCCCCCCCC1) |ctu:1|"_smiles;
      REQUIRE(m);
      CHECK(m->getBondWithIdx(1)->getStereo() == Bond::STEREOANY);
      CHECK(m->getBondWithIdx(1)->getStereoAtoms() == std::vector<int>{0, 3});
    }
  }
  SECTION("as reported") {
    // technically these are only valid in rings, but we allow them elsewhere
    {
      auto m = "CC(F)=C(C)F |c:2|"_smiles;
      REQUIRE(m);
      CHECK(m->getBondWithIdx(2)->getStereo() == Bond::STEREOCIS);
      CHECK(m->getBondWithIdx(2)->getStereoAtoms() == std::vector<int>{0, 4});
    }
    {
      auto m = "CC(F)=C(C)F |t:2|"_smiles;
      REQUIRE(m);
      CHECK(m->getBondWithIdx(2)->getStereo() == Bond::STEREOTRANS);
      CHECK(m->getBondWithIdx(2)->getStereoAtoms() == std::vector<int>{0, 4});
    }
    {
      auto m = "CC(F)=C(C)F |ctu:2|"_smiles;
      REQUIRE(m);
      CHECK(m->getBondWithIdx(2)->getStereo() == Bond::STEREOANY);
      CHECK(m->getBondWithIdx(2)->getStereoAtoms() == std::vector<int>{0, 4});
    }
  }
}

TEST_CASE("Github #8348: Unable to write wiggly bond information by default") {
  auto test_input = GENERATE(
      "CC(O)Cl |w:1.0|",
      "CC(Cl)(Br)C=C[C@@](C)(N)Cl |(4.9105,-2.4464,;4.1235,-2.6938,;4.7314,-3.2517,;3.9443,-3.4991,;3.2367,-1.8799,;2.4117,-1.8799,;1.6973,-1.4674,;0.9435,-1.803,;1.6973,-0.6424,;1.654,-2.2913,),w:4.3,wU:6.5|",
      "CC(Cl)(Br)C=C[C@@](C)(N)Cl |(4.9105,-2.4464,;4.1235,-2.6938,;4.7314,-3.2517,;3.9443,-3.4991,;3.2367,-1.8799,;2.4117,-1.8799,;1.6973,-1.4674,;0.9435,-1.803,;1.6973,-0.6424,;1.654,-2.2913,),w:4.3,wD:6.5|"

  );
  CAPTURE(test_input);

  auto mol = v2::SmilesParse::MolFromSmiles(test_input);
  // make sure mol is valid
  REQUIRE(mol);
  CHECK(mol->getNumAtoms() > 0);
  CHECK(mol->getNumBonds() > 0);

  // the default conversion
  {
    const auto output_cxsmiles = MolToCXSmiles(*mol);
    // we should always be able to write wiggly bond information
    CHECK(output_cxsmiles.find("w:") != std::string::npos);
  }

  // testing the RestoreBondDirOption parameter
  {
    auto bond_dir_option =
        GENERATE(RestoreBondDirOptionClear, RestoreBondDirOptionTrue);
    CAPTURE(bond_dir_option);

    const SmilesWriteParams ps;
    const auto flags = SmilesWrite::CXSmilesFields::CX_ALL;

    const auto output_cxsmiles =
        MolToCXSmiles(*mol, ps, flags, bond_dir_option);
    // we should always be able to write wiggly bond information
    CHECK(output_cxsmiles.find("w:") != std::string::npos);
  }
}

TEST_CASE("Github #8586: MolFromSmiles loses atom maps if cxsmiles is used") {
  SECTION("as reported") {
    auto m = "[CH3:3]N([*:1])C[C@](C([*:2])=O)([H])CS |o1:4|"_smiles;
    REQUIRE(m);
    CHECK(m->getAtomWithIdx(0)->getAtomMapNum() == 3);
    CHECK(m->getAtomWithIdx(2)->getAtomMapNum() == 1);
    CHECK(m->getAtomWithIdx(6)->getAtomMapNum() == 2);
  }
  SECTION("additional properties") {
    auto m =
        "[CH3:3]N([*:1])C[C@](C([*:2])=O)([H])CS |atomProp:7.dummyLabel.d:2.dummyLabel.d,o1:4|"_smiles;
    REQUIRE(m);
    CHECK(m->getAtomWithIdx(2)->getAtomMapNum() == 1);
    CHECK(m->getAtomWithIdx(6)->getAtomMapNum() == 2);
    std::string dlabel;
    CHECK(m->getAtomWithIdx(7)->getPropIfPresent(common_properties::dummyLabel,
                                                 dlabel));
    CHECK(dlabel == "d");
    CHECK(m->getAtomWithIdx(2)->getPropIfPresent(common_properties::dummyLabel,
                                                 dlabel));
    CHECK(dlabel == "d");
  }
}

TEST_CASE("Test CXSmilesFields option parsing from JSON") {
  SECTION("Empty JSON string preserves current values") {
    std::uint32_t cxSmilesFields =
        SmilesWrite::CXSmilesFields::CX_ALL_BUT_COORDS;
    unsigned int restoreBondDirs = RestoreBondDirOptionClear;
    updateCXSmilesFieldsFromJSON(cxSmilesFields, restoreBondDirs, "{}");
    CHECK(cxSmilesFields == SmilesWrite::CXSmilesFields::CX_ALL_BUT_COORDS);
    CHECK(restoreBondDirs == RestoreBondDirOptionClear);
  }
  SECTION("No CXSmilesFields key preserves current values") {
    std::uint32_t cxSmilesFields =
        SmilesWrite::CXSmilesFields::CX_ALL_BUT_COORDS;
    unsigned int restoreBondDirs = RestoreBondDirOptionTrue;
    updateCXSmilesFieldsFromJSON(
        cxSmilesFields, restoreBondDirs,
        "{\"restoreBondDirOption\":\"RestoreBondDirOptionClear\"}");
    CHECK(cxSmilesFields == SmilesWrite::CXSmilesFields::CX_ALL_BUT_COORDS);
    CHECK(restoreBondDirs == RestoreBondDirOptionClear);
  }
  SECTION("Multiple CXSmilesFields keys with true value are ORed together") {
    std::uint32_t cxSmilesFields = SmilesWrite::CXSmilesFields::CX_ALL;
    unsigned int restoreBondDirs = RestoreBondDirOptionClear;
    updateCXSmilesFieldsFromJSON(
        cxSmilesFields, restoreBondDirs,
        "{\"CX_MOLFILE_VALUES\":true,\"CX_COORDS\":true}");
    CHECK(cxSmilesFields == (SmilesWrite::CXSmilesFields::CX_MOLFILE_VALUES |
                             SmilesWrite::CXSmilesFields::CX_COORDS));
    CHECK(restoreBondDirs == RestoreBondDirOptionClear);
  }
  SECTION(
      "Multiple CXSmilesFields keys with true value are ORed together; adding unrelated false values makes no difference") {
    std::uint32_t cxSmilesFields = SmilesWrite::CXSmilesFields::CX_ALL;
    unsigned int restoreBondDirs = RestoreBondDirOptionClear;
    updateCXSmilesFieldsFromJSON(
        cxSmilesFields, restoreBondDirs,
        "{\"CX_MOLFILE_VALUES\":true,\"CX_COORDS\":true,\"CX_ATOM_PROPS\":false,\"CX_BOND_CFG\":false}");
    CHECK(cxSmilesFields == (SmilesWrite::CXSmilesFields::CX_MOLFILE_VALUES |
                             SmilesWrite::CXSmilesFields::CX_COORDS));
    CHECK(restoreBondDirs == RestoreBondDirOptionClear);
  }
  SECTION(
      "Multiple CXSmilesFields keys with true value are ORed together, then AND NOTed with ORed false values") {
    std::uint32_t cxSmilesFields = SmilesWrite::CXSmilesFields::CX_ALL;
    unsigned int restoreBondDirs = RestoreBondDirOptionClear;
    updateCXSmilesFieldsFromJSON(cxSmilesFields, restoreBondDirs,
                                 "{\"CX_ALL\":true,\"CX_COORDS\":false}");
    CHECK(cxSmilesFields == SmilesWrite::CXSmilesFields::CX_ALL_BUT_COORDS);
    CHECK(restoreBondDirs == RestoreBondDirOptionClear);
  }
  SECTION(
      "Multiple CXSmilesFields keys with true value are ORed together, then AND NOTed with ORed false values; order does not matter") {
    std::uint32_t cxSmilesFields = SmilesWrite::CXSmilesFields::CX_ALL;
    unsigned int restoreBondDirs = RestoreBondDirOptionClear;
    updateCXSmilesFieldsFromJSON(cxSmilesFields, restoreBondDirs,
                                 "{\"CX_COORDS\":false,\"CX_ALL\":true}");
    CHECK(cxSmilesFields == SmilesWrite::CXSmilesFields::CX_ALL_BUT_COORDS);
    CHECK(restoreBondDirs == RestoreBondDirOptionClear);
  }
}

TEST_CASE("atom maps and dummy labels in CXSMILES") {
  SECTION("basics") {
    auto m = "CC[*:1]"_smiles;
    REQUIRE(m);
    CHECK(m->getAtomWithIdx(2)->hasProp(common_properties::dummyLabel));
    CHECK(m->getAtomWithIdx(2)->hasProp(common_properties::molAtomMapNumber));
    CHECK(MolToCXSmiles(*m) == "CC[*:1]");
    m->getAtomWithIdx(2)->setProp(common_properties::dummyLabel, "R1");
    CHECK(MolToCXSmiles(*m) == "CC[*:1] |atomProp:2.dummyLabel.R1|");
  }
}

TEST_CASE("duplicate atoms in StereoGroup") {
  SECTION("as reported") {
    std::string smiles = "C[C@H](F)[C@H](C)[C@@H](C)Br |a:1,o1:3,3|";

    CHECK_THROWS_AS(SmilesToMol(smiles), SmilesParseException);
  }
}